Skip to content

test: Add more tests and update some tests #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 17, 2025
Merged

test: Add more tests and update some tests #2046

merged 4 commits into from
Jun 17, 2025

Conversation

@RyanJWard
Copy link
Contributor

@RyanJWard RyanJWard commented Jun 17, 2025 •
edited
Loading

Description

Expand test coverage in:
tools\check_geometry.py
tools\prepare_tools.py
tools\problem_areas.py
tools\repair_tools.py
Fix:
FindStitchFacesRequest maximum_distance

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RyanJWard RyanJWard self-assigned this Jun 17, 2025
@RyanJWard RyanJWard requested a review from a team as a code owner June 17, 2025 17:04
@RyanJWard RyanJWard added the testing Anything related to tests label Jun 17, 2025
@github-actions github-actions bot removed the testing Anything related to tests label Jun 17, 2025
@codecov
Copy link

codecov bot commented Jun 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.15%. Comparing base (9eb0921) to head (386383e).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2046      +/-   ##
==========================================
+ Coverage   91.71%   92.15%   +0.43%     
==========================================
  Files         136      136              
  Lines        9810     9811       +1     
==========================================
+ Hits         8997     9041      +44     
+ Misses        813      770      -43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

RobPasMue
RobPasMue approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RyanJWard RyanJWard merged commit 4a3dda3 into main Jun 17, 2025
45 checks passed
@RyanJWard RyanJWard deleted the test/expand_code_coverage_2 branch June 17, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@jacobrkerstetter jacobrkerstetter Awaiting requested review from jacobrkerstetter

@craig-connelly craig-connelly Awaiting requested review from craig-connelly

@syscordan syscordan Awaiting requested review from syscordan

Assignees

@RyanJWard RyanJWard

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RyanJWard @RobPasMue @pyansys-ci-bot